Skip to content
This repository has been archived by the owner on Mar 16, 2019. It is now read-only.

Unicode characters in response body does not encoded correctly #73

Closed
3 tasks done
wkh237 opened this issue Aug 3, 2016 · 1 comment
Closed
3 tasks done

Unicode characters in response body does not encoded correctly #73

wkh237 opened this issue Aug 3, 2016 · 1 comment
Assignees
@wkh237 @puresmash
Labels
android bug ios ready to merge
Milestone
v0.9.0

Comments

@wkh237
Copy link
Owner

wkh237 commented Aug 3, 2016 •
edited

When response data contains unicode characters response.json() and response.text() does not convert unicode character correctly. We should check if the response data is a valid UTF8 string before encode it to BASE64 string. When it's valid, use URL encoding before BASE64.

  • Android
  • IOS
  • Test case
wkh237 added a commit that referenced this issue Aug 3, 2016
@wkh237
Fix response unicode issue on Android #73
f118228
wkh237 added a commit that referenced this issue Aug 4, 2016
@wkh237
Add fetch polyfill Blob reader method #70
1bbe292 
Fix Blob unicode data convertion #73
wkh237 added a commit that referenced this issue Aug 5, 2016
@wkh237
Fix unicode write file issue #73
5e5a461
@wkh237 wkh237 added this to the v0.9.0 milestone Aug 6, 2016
@wkh237
Copy link
Owner Author

wkh237 commented Aug 13, 2016

close on 0.9.0 release

@wkh237 wkh237 closed this as completed Aug 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@wkh237 wkh237

@puresmash puresmash

Labels
android bug ios ready to merge
Projects
None yet
Milestone
v0.9.0
Development

No branches or pull requests
2 participants
@wkh237 @puresmash