This repository has been archived by the owner on Mar 16, 2019. It is now read-only.
Fix XMLHttpRequest event listeners #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sprmn , Great 👍 Let me merge this PR and do some tests, hope we can solve these issues. |
|
@sprmn Thank you so much for fixing this issue :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #187 and #179, by making the dispatch of events to listeners and the removal of listeners work in the XMLHttpRequest polyfill.
Problems occurring with the newest version of firebase (3.6.1), which probably makes use of event listeners, should be solved now.