Skip to content
This repository has been archived by the owner on Mar 16, 2019. It is now read-only.

Fix for issue #468, #461, #460 and minor cleanup #469

Merged
merged 7 commits into from
Aug 9, 2017
Merged

Fix for issue #468, #461, #460 and minor cleanup #469

merged 7 commits into from
Aug 9, 2017

Commits on Aug 3, 2017

  1. bump to 0.10.8

    bcpclone committed Aug 3, 2017
    Configuration menu
    Copy the full SHA
    9ab4ebb View commit details
    Browse the repository at this point in the history
  2. Update PULL_REQUEST_TEMPLATE

    wkh237 committed Aug 3, 2017
    Configuration menu
    Copy the full SHA
    1336555 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2017

  1. Configuration menu
    Copy the full SHA
    2aaad4d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d877f16 View commit details
    Browse the repository at this point in the history
  3. Cleanup:

    - fix minor errors in JSDoc comments, for example {string]} => {string}
    - fix parameter name "encode" => "encoding" (more logical, and it says so in the function's JSDoc too)
    - json-stream.js: split a looooong log message string constant into two parts and fix a typo ("maually"), and the type for objects is "Object" (capitalized) in Flow type annotations
    lll000111 committed Aug 8, 2017
    Configuration menu
    Copy the full SHA
    6e4169c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    314f457 View commit details
    Browse the repository at this point in the history
  5. NEEDS REVIEW - Attempt to fix some of issue #460 (Error message norma…

    …lization)
    
    Error messages reported by iOS and Android versions should be as similar as possible. Also, within the same system there should be consistency. This patch is an attempt to bring a LITTLE more of this consistency to the error messages. I also fixed some very few minor language issues, like "does not exist" (is the correct English). I tried keeping the changes to a minimum.
    
    Background: In my project code I want to know when a file already exists (e.g. after calling fs.createFile), and the only way is to check the error message string that I get. It's bad if they differ between versions (createFileASCII and createFile) and then also between Android and iOS version. At least some core part of the string should be the same, so that I have something to match.
    
    Ideally messages should come from a centralized easy (easier) to maintain file (for both iOS and Android), and ideally both systems should have the same errors and messages as far as possible.
    lll000111 committed Aug 8, 2017
    Configuration menu
    Copy the full SHA
    d5980cd View commit details
    Browse the repository at this point in the history