This repository has been archived by the owner on Mar 16, 2019. It is now read-only.
Add ability to cancel android DownloadManager fetches #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just requires a bit of bookkeeping that keeps track of the task ID to the download manager ID. Note that the behavior of the download manager remove method is to remove the download and the downloaded file, whether partial or complete. https://developer.android.com/reference/android/app/DownloadManager.html#remove(long...)
wkh237
approved these changes
Aug 31, 2017
danielsuo
added a commit
to danielsuo/react-native-fetch-blob
that referenced
this pull request
Feb 13, 2018
* upstream/0.10.9: Fixed problem with type casting (wkh237#513) My proposed 0.10.9 changes (wkh237#489) wkh237#268 Cancelled task should not trigger `then` promise function Add ability to cancel android DownloadManager fetches (wkh237#502) Fix iOS initialization race condition (wkh237#499) prevent UIApplication methods from being called on background thread (wkh237#486) Implemenet fs.hash() -- wkh237#439 "Feature: Calculate file hash" (wkh237#476) I forgot one error string for the Android readFile() method (wkh237#475) Fix for wkh237#467 (wkh237#472) Fix for issue wkh237#468, wkh237#461, wkh237#460 and minor cleanup (wkh237#469)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not completely sure whether this is considered a new feature or a bugfix, but since this behavior may be expected I figured it might be a bugfix. Happy to move PR to 0.11.0 if desired.
This just requires a bit of bookkeeping that keeps track of the task ID to the download manager ID, and then calling the relevant download manager method. Note that the behavior of the download manager remove method is to remove the download and the downloaded file, whether partial or complete (https://developer.android.com/reference/android/app/DownloadManager.html#remove(long...)).
Happy to answer any questions and always looking for review/comments on the approach.