Fix Crash In React Native 0.50 & 0.51

[huhuanming]

solved cannot find self temporarily by this way and will open a PR in oboe lately.

[Freddy03h]

This change doesn't fix the issue in my project (RN 0.50.1, after deleted node_modules, re-yarn and XCode > Product > Clean)

It seems that global and window are the same object on Debug Mode, and we still go to the catch on Release Mode.

[huhuanming]

But work well in my project...

it seems that your project includes other issues, not only this.

[Freddy03h]

Hum, weird…

What's you config ?

Mine:

• macOS 10.13.1
• XCode 9.1
• iOS 11.1 (simulator and real device)
• node 8.7.0
• yarn 1.2.1

[huhuanming]

Me too, my config is same as your.

[aforty]

@Freddy03h Try running watchman watch-del-all && rm -rf $TMPDIR/react-* and react-native start --reset-cache.

This branch works for me.

[Freddy03h]

@aforty I tried it, I also tried after updating node (9.1.0) and yarn (1.3.2), I also restart my computer…

But i still get the same issue on Release Mode : Got JS Exception: Can't find variable: window ( … main.jsbundle:534) on XCode, with @huhuanming fork
This issue is also described by @bnjm : #588 (comment)

No problem to build on Debug Mode, but the main.jsbundle for the Release version emits this error at runtime.

[huhuanming]

check your yarn.lock and find react-native-fetch-blob.

[bnjm]

@Freddy03h I realised my window issue is actually coming from another module that includes a polyfill.

Seems like there are a number of release-only bugs relating to globals, which suggests an issue with the bundler. See here:

GeekyAnts/NativeBase#1348 (comment)

[Freddy03h]

@bnjm Oh yes I just find that the JS Exception Can't find variable: window is emitted by an other module.

Thank you all !

[aforty]

The bundler definitely has an issue in 0.50.x. I discovered another Android-only issue where Promise is not defined, again only in the production bundle. I downgraded to 0.49.5 for now.

[aforty]

FYI, react-native 0.50.3 is out and it fixes this (and my other) bundler issue(s).

[Freddy03h]

I'm still stuck with the same issue described here : GeekyAnts/NativeBase#1348 (but I don't use NativeBase)

Anyways, It's no more related to react-native-fetch-blob.

[huhuanming]

@Freddy03h Freddy

Check your yarn.lock, maybe you can Found the parent of NativeBase.

[huhuanming]

It was fix in React Native 0.50.3, I will close this PR now.