Adds Fedora 36 and 37 build targets #135
Conversation
There was a problem hiding this comment.
@innovara also, you should use the 0.12.6.x branch for making builds -- I think I pointed it out in the other issue.
Also, is there any reason to support Fedora 36? My understanding is that people on Fedora tend to upgrade regularly, plus it's not an LTS distribution 🤷♂️
docker/Dockerfile.fedora
Outdated
| openssl-devel \ | ||
| perl \ | ||
| zlib-devel \ | ||
| qtwebkit-devel \ |
There was a problem hiding this comment.
Why do you need this? If not for this package, you could use Dockerfile.centos as-is (I think yum is still supported on Fedora, right?).
If this pulls in packages which are required, I'd want them to be explicitly listed instead of qtwebkit-devel.
There was a problem hiding this comment.
Why do you need this? If not for this package, you could use
Dockerfile.centosas-is (I think yum is still supported on Fedora, right?).
In fact, it's not needed. I thought it solved a problem when compiling qt but that's not the case.
Regarding using yum in Fedora, yes, you can use it. Currently /usr/bin/yum is a symbolic link to dnf-3, same as /usr/bin/dnf
If this pulls in packages which are required, I'd want them to be explicitly listed instead of
qtwebkit-devel.
qtwebkit-devel requires qt-devel but it is not needed anyway.
Noted, thanks. I see that the
Not really. Fedora 36's EOL is in May 2023. I just thought that if it compiles, why not? It might be of some use to someone... |
It is possible to build wkhtmltopdf for Fedora 36 and 37 with the changes included in this commit.
Tested for x86_64 and aarch64 builds.