This repository has been archived by the owner on Aug 28, 2023. It is now read-only.
massive revamp to support additional targets #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the need to call docker-images manually, plus change it: * remove --push as it is now redundant * add --force to rebuild images from scratch
Now that we aren't pre-building a docker image but doing it dynamically, it doesn't make sense to build for both together.
This is done via a new "matrix" key, which automatically generates new targets for each supported architecture. We have an explicit mapping from distro architecture => docker platform, as the naming conventions vary wildly. Also switch to a new image for qemu: https://github.com/dbhi/qus and make sure we enable it only if it's really required. Have to always use the 32-bit version due to a bug with glibc 2.28+, see https://bugs.launchpad.net/qemu/+bug/1805913 for details.
Now that some of the targets are generated on the fly, it makes sense to add a list-targets command. We also won't be doing any "full" release for all supported targets, so do away with that.
This was done by running the following command: ./build docker-images `./build list-targets | grep docker | cut -f2 | xargs` While there is no guarantee that a build will work properly, there's at least hope that a build will be successful.
This has timed out multiple times, probably due to the 32-bit emulation required to workaround the qemu bug [1]. This will also be useful as emulated builds can often take over 6 hours leading to timeouts with the Azure hosted agents. [1] https://bugs.launchpad.net/qemu/+bug/1805913
This was referenced Jun 2, 2020
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the configuration and adds to support for alternative architectures. A run will be done on the targets defined in
.azure-pipelines.yml-- this is equivalent to building it yourself, as docker images are no longer published and built on-the-fly.fixes #6
fixes #30
fixes #50