Skip to content
This repository has been archived by the owner on Jan 2, 2023. It is now read-only.

Commit

Permalink
win32-msvc2015: Fix LNK2019: unresolved external symbol
Browse files Browse the repository at this point in the history
Fix LNK2019: unresolved external symbol "private: static void __cdecl QTJSC::MarkedArgumentBuffer::operator delete(void *,unsigned int)" (??3MarkedArgumentBuffer@QTJSC@@CAXPAXI@Z) referenced in function __unwindfunclet$??0JSGlobalData@QTJSC@@aae@_N@Z$22

Remove private "void* MarkerArgumentBuffer::operator new(size_t,
void*);" declaration as it is an overload with user specific
arguments, ie not one that will ever be supplied by the compiler. Also
remove "void MarkerArgumentBuffer::operator delete(void*, size_t);" as
it does not make sense to supply both that and "static void* operator
new(size_t size)". It is this latter overload that somehow trips the
GA version of Visual Studio 2015 (GA).

Change-Id: I47eea4322feac12f75f80e7858b9602a4036e562
  • Loading branch information
Thomas Sondergaard authored and ashkulz committed May 30, 2016
1 parent 8dae19a commit bc8546d
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
3 changes: 0 additions & 3 deletions src/3rdparty/javascriptcore/JavaScriptCore/runtime/ArgList.h
Original file line number Diff line number Diff line change
Expand Up @@ -170,9 +170,6 @@ namespace JSC {

void* operator new[](size_t);
void operator delete[](void*);

void* operator new(size_t, void*);
void operator delete(void*, size_t);
};

class ArgList {
Expand Down
3 changes: 0 additions & 3 deletions src/3rdparty/webkit/Source/JavaScriptCore/runtime/ArgList.h
Original file line number Diff line number Diff line change
Expand Up @@ -172,9 +172,6 @@ namespace JSC {

void* operator new[](size_t);
void operator delete[](void*);

void* operator new(size_t, void*);
void operator delete(void*, size_t);
};

class ArgList {
Expand Down

0 comments on commit bc8546d

Please sign in to comment.