Skip to content
This repository has been archived by the owner on Jan 2, 2023. It is now read-only.

viewportSize not reflected in API #2609

Closed
bornste opened this issue Sep 30, 2015 · 12 comments
Closed

viewportSize not reflected in API #2609

bornste opened this issue Sep 30, 2015 · 12 comments
Labels
Milestone

Comments

@bornste
Copy link

bornste commented Sep 30, 2015

The setting viewportSize cannot be set by the API because it is missing in the ReflectImpl<PdfGlobal> struct.

@rdvojmoc
Copy link
Contributor

Can we expect setting viewportSize to come back to API at some point?

@ashkulz
Copy link
Member

ashkulz commented Apr 18, 2017

@rdvojmoc: would be happy to receive a PR, it's a very small fix 😄

@ashkulz ashkulz added the Verified The issue is verified. label Apr 18, 2017
@ashkulz ashkulz added this to the 0.12.5 milestone Apr 18, 2017
@OskarStark
Copy link

@ashkulz as this this issue already has a merged PR (#3440) we can close is.

After closing this issue, the Milestone for 0.12.5 is completed. A new release would be great 👍

@melroy89
Copy link

melroy89 commented Jan 10, 2018

@ashkulz YEA release 0.12.5! plz? 😄

@OskarStark
Copy link

can you please create a release?

@MrMitch
Copy link

MrMitch commented Feb 20, 2018

@ashkulz Hi, thanks for your work on this project.
It seems that PR #3440 implements this, and it has been merged. This was the last issue for the 0.12.5 milestone, so do you know if there's anything more that needs to be contributed for a release ?
The 0.12.5 release is especially awaited because it solves #3241 which has be problematic on Linux and Mac for more than a year now.
How can we help ?

@OskarStark
Copy link

OskarStark commented Mar 15, 2018

Can you guys please create a release?

@ashkulz ashkulz added Fixed and removed Verified The issue is verified. labels Apr 29, 2018
@ashkulz
Copy link
Member

ashkulz commented Apr 29, 2018

Currently working on a reworked packaging system in the wkhtmltopdf/packaging repository, you can download preview builds for linux. For OS X and Windows, trying to automate the build using vagrant so a release can be created easily.

Planning to release a -rc by next weekend, and a release after a week .. so expect May 15 for the 0.12.5 release.

@ashkulz ashkulz closed this as completed Apr 29, 2018
@ashkulz
Copy link
Member

ashkulz commented May 30, 2018

A release candidate is available which includes the fixes made in PR #3440 -- please test and report your findings before the final release.

@OskarStark
Copy link

hey @ashkulz thank you 👍

could you make the RC available on github releases:
https://github.com/wkhtmltopdf/wkhtmltopdf/releases

@ashkulz
Copy link
Member

ashkulz commented May 30, 2018

I plan to make only the final release available, as no one cares for -rc after that. No point in wasting storage space...

@OskarStark
Copy link

ok thank you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

6 participants