New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viewportSize not reflected in API #2609

Closed
bornste opened this Issue Sep 30, 2015 · 12 comments

Comments

Projects
None yet
6 participants
@bornste

bornste commented Sep 30, 2015

The setting viewportSize cannot be set by the API because it is missing in the ReflectImpl<PdfGlobal> struct.

@rdvojmoc

This comment has been minimized.

Contributor

rdvojmoc commented Apr 18, 2017

Can we expect setting viewportSize to come back to API at some point?

@ashkulz

This comment has been minimized.

Member

ashkulz commented Apr 18, 2017

@rdvojmoc: would be happy to receive a PR, it's a very small fix 😄

@OskarStark

This comment has been minimized.

OskarStark commented Jan 3, 2018

@ashkulz as this this issue already has a merged PR (#3440) we can close is.

After closing this issue, the Milestone for 0.12.5 is completed. A new release would be great 👍

@danger89

This comment has been minimized.

danger89 commented Jan 10, 2018

@ashkulz YEA release 0.12.5! plz? 😄

@OskarStark

This comment has been minimized.

OskarStark commented Jan 22, 2018

can you please create a release?

@MrMitch

This comment has been minimized.

MrMitch commented Feb 20, 2018

@ashkulz Hi, thanks for your work on this project.
It seems that PR #3440 implements this, and it has been merged. This was the last issue for the 0.12.5 milestone, so do you know if there's anything more that needs to be contributed for a release ?
The 0.12.5 release is especially awaited because it solves #3241 which has be problematic on Linux and Mac for more than a year now.
How can we help ?

@OskarStark

This comment has been minimized.

OskarStark commented Mar 15, 2018

Can you guys please create a release?

@ashkulz ashkulz added Fixed and removed Verified labels Apr 29, 2018

@ashkulz

This comment has been minimized.

Member

ashkulz commented Apr 29, 2018

Currently working on a reworked packaging system in the wkhtmltopdf/packaging repository, you can download preview builds for linux. For OS X and Windows, trying to automate the build using vagrant so a release can be created easily.

Planning to release a -rc by next weekend, and a release after a week .. so expect May 15 for the 0.12.5 release.

@ashkulz ashkulz closed this Apr 29, 2018

@ashkulz

This comment has been minimized.

Member

ashkulz commented May 30, 2018

A release candidate is available which includes the fixes made in PR #3440 -- please test and report your findings before the final release.

@OskarStark

This comment has been minimized.

OskarStark commented May 30, 2018

hey @ashkulz thank you 👍

could you make the RC available on github releases:
https://github.com/wkhtmltopdf/wkhtmltopdf/releases

@ashkulz

This comment has been minimized.

Member

ashkulz commented May 30, 2018

I plan to make only the final release available, as no one cares for -rc after that. No point in wasting storage space...

@OskarStark

This comment has been minimized.

OskarStark commented May 30, 2018

ok thank you

@AndyCJ AndyCJ referenced this issue Jun 18, 2018

Open

viewport-size #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment