Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxying #1

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Add proxying #1

merged 1 commit into from
Oct 9, 2018

Conversation

aeons
Copy link
Contributor

@aeons aeons commented Sep 7, 2018

Reimplementation of wking-io/elm-live#128

I'm not completely clear on whether this is the best way to add the feature, but it seems to work.

Eg. node bin/elm-serve.js --proxyPrefix api --proxyHost 'http://localhost:9000' works as expected and will proxy http://localhost:8080/api/test to http://localhost:9000/api/test.

@Dubbelll
Copy link

Dubbelll commented Oct 8, 2018

I just wanted to express my support for this feature.
I have the exact same use case as described in the original post: proxying a separate backend running on a different port than the frontend.

Thank you for making this wonderful tool and thank you for making this pull request!

@wking-io
Copy link
Owner

wking-io commented Oct 9, 2018

I am going to go ahead and merge this! We can let the users of this report any issues and I will reach out to you if they occur @aeons!

@wking-io wking-io merged commit 784db1c into wking-io:master Oct 9, 2018
@aeons aeons deleted the proxy branch October 9, 2018 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants