Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a filetype check BEFORE loading any files #21

Closed
wkumler opened this issue Sep 25, 2023 · 1 comment
Closed

add a filetype check BEFORE loading any files #21

wkumler opened this issue Sep 25, 2023 · 1 comment

Comments

@wkumler
Copy link
Owner

wkumler commented Sep 25, 2023

I keep getting burned by non-mzML files included in the pass to grabMSdata, but I only find out about it after I've sunk a bunch of time into extracting all the actual mzMLs first until it hits one and crashes. Two solutions for later: one, check the filetype before loading any of the files which is simple enough to do by checking the extension but might throw some false positives; or two, throw a warning that the file type isn't recognized and ignore it. Adding to the v1.4 milestone maybe?

@wkumler wkumler mentioned this issue Nov 13, 2023
9 tasks
@wkumler
Copy link
Owner Author

wkumler commented Nov 30, 2023

Completed with #24

@wkumler wkumler closed this as completed Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant