Version 1.3.2 #24
Merged
Version 1.3.2 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementing check-namespace function when reading in mzML, needs testing
Replacing awkward and inefficient Reduce(Map()) construction even if it was fun to use both in the same line
rbindlist() complains where rbind() filled
Upgraded from warning to error and didn't change unit check to reflect
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 85.31% 85.57% +0.26%
==========================================
Files 5 6 +1
Lines 1171 1276 +105
==========================================
+ Hits 999 1092 +93
- Misses 172 184 +12 ☔ View full report in Codecov by Sentry. |
Merge branch 'version_1.3.2' of https://github.com/wkumler/RaMS into version_1.3.2 # Conflicts: # .github/workflows/r-check-cran.yml
This was referenced Nov 30, 2023
Closed
I just can't pass checks with it. It requires netcdf which is a complicated install on Linux and it's not worth it for a few lines in the single vignette.
sample() can return the input vector occasionally, not sure how to guarantee avoidance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements RaMS version 1.3.2, with read access expanded to OpenChrom documents (credit to @ethanbass), additional helper functions, and some bugs squashed.