Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable multinomial logistic regression to allow alternate classifications #2

Open
wkumler opened this issue Mar 25, 2024 · 1 comment

Comments

@wkumler
Copy link
Owner

wkumler commented Mar 25, 2024

While "good" and "bad" are useful classes for training, there's no real reason why we couldn't create additional classifications that are automatically categorized - e.g. "solvent peak" or "only in standards". Not sure how well the med_snr and med_cor metrics alone would be able to separate these but with additional ones (maybe sample_type?) this should be totally doable.

@wkumler
Copy link
Owner Author

wkumler commented Mar 26, 2024

I wonder if the best way to go about this is to have the user supply the regression formula? Like the default would be feat_class~med_cor+med_snr but there's no reason we should ban the user from providing their own. Would require a bunch of error handling but doesn't actually feel that difficult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant