Fedora spec02 #15
Open
Fedora spec02 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er allow md5 Make sure PREFIX/bin exists Copy binary with preserve so permissions and timestamp remain. Signed-off-by: Stephen Smoogen <ssmoogen@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the package as an RPM, I found that the PREFIX/bin didn't exist [and found it also in a different system.] so I added a -p to try and make it if it doesn't exist already.
Also found that the cp didn't preserve certain information on the copy which caused both the debuginfo tooling to fail and required permissions to be explicitely set on the file by the package. Reviewer mentioned that a
cp -pwould fix this so I have added that also. https://bugzilla.redhat.com/show_bug.cgi?id=2258110