Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate retries in crew #100

Closed
1 task done
shikokuchuo opened this issue Jul 27, 2023 · 1 comment
Closed
1 task done

Eliminate retries in crew #100

shikokuchuo opened this issue Jul 27, 2023 · 1 comment
Labels
type: maintenance

Comments

@shikokuchuo
Copy link
Contributor

Prework

Re. #76 around the timeouts and my fix in mirai shikokuchuo/mirai@3f15ead for ropensci/targets#1101. There shouldn't logically be the need for retries for status() calls. I think having them may mask real issues, if they still exist.

I am not sure if you implemented them or not in the end so by all means ignore if you didn't!
wlandau-lilly added a commit that referenced this issue Jul 27, 2023
@wlandau-lilly
Fix #100
b73abe7
@wlandau
Copy link
Owner

wlandau commented Jul 27, 2023

Sure, that sounds fine. Implemented in cd1f4e9. I agree it will be good to see if max_tries = 1L uncovers any remaining hidden issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wlandau @shikokuchuo