Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "internal" installation #16

Closed
wlandau opened this issue Jan 9, 2024 · 0 comments
Closed

Remove "internal" installation #16

wlandau opened this issue Jan 9, 2024 · 0 comments

Comments

@wlandau
Copy link
Owner

wlandau commented Jan 9, 2024

According to https://cran.r-project.org/doc/manuals/R-exts.html#Package-subdirectories (c.f. #12), the correct way to install a custom binary inside an R package is through src/install.libs.R. When instantiate installs CmdStan inside itself this way (i.e. "internal" installation), CmdStan hard-codes full paths to its own bundled resources. These hard-coded paths are established during staged installation, and they all break when the package is moved from the staging area to the final installed location. In other words, "internal" installation only works if instantiate uses staged installation. I tried submitting a CRAN update with StagedInstall: no in the DESCRIPTION file, and I got a NOTE in the automated checks, which triggered an email saying "Dear maintainer, package instantiate_0.1.0.tar.gz does not pass the incoming checks automatically". It looks like a package that use staged installation is always going to trigger a manual review, which is asking for more trouble than it's worth. And without staged installation, "internal" installation becomes infeasible.

wlandau-lilly added a commit that referenced this issue Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant