Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broker blacklisting can lead to endless loop if some brokers are fully offline #87

Closed
RalfJung opened this issue Jan 8, 2019 · 0 comments
Closed

Broker blacklisting can lead to endless loop if some brokers are fully offline #87

RalfJung opened this issue Jan 8, 2019 · 0 comments

Comments

@RalfJung
Copy link
Member

RalfJung commented Jan 8, 2019

The tunneldigger clients tries to avoid selecting the same broker again and it again if it gets a connection error. It blacklists a broker upon error and tries the others, until all failed and they all get unblacklisted again.

Unfortunately, I just observed that this can lead to an endless loop: Say two brokers are configured, of which one is offline and one errors. The erroring one will get blacklisted, but the one that is offline will not. Now the client just keeps trying the offline broker, so even if the one that is online stops erroring, it does not get used.
@RalfJung RalfJung mentioned this issue Jan 8, 2019
Merged
@cmarxmeier cmarxmeier mentioned this issue Mar 28, 2019
Closed
@RalfJung RalfJung changed the title Broker blacklisting can lead to endless loop of some brokers are fully offline Broker blacklisting can lead to endless loop if some brokers are fully offline Mar 28, 2019
@RalfJung RalfJung mentioned this issue Mar 31, 2019
Closed
cmarxmeier referenced this issue in cmarxmeier/packages Apr 10, 2019
@cmarxmeier
Update Makefile
dfecf1f
rotanid pushed a commit to freifunk-gluon/packages that referenced this issue Apr 11, 2019
@cmarxmeier @rotanid
tunneldigger: update to newest upstream commit (#216)
524ae77 
- fixes broken Broker reset bug in tunneldigger-client wlanslovenija/tunneldigger#87 - now tunneldigger client resets error-tags and starts from scratch, when no Brokers are left over
- added cmake related patches to Makefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RalfJung