Reintroduce: Remove NAT logic (v2) #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
reviewed
Mar 6, 2020
RalfJung
reviewed
Mar 6, 2020
Add a link to useful information on this particular error which is most likely triggered by a bug in the Kernel. This should give users a way to identify if they are affected and give them hints on how to rectify the situation. Signed-off-by: Felix Kaechele <felix@kaechele.ca>
This reverts commit a461a11.
|
I adjusted the issue some more: from what I could see, the faulty commit landed in 4.5, but the 4.4 kernel should be unaffected. |
RalfJung
approved these changes
Mar 7, 2020
|
I'm afraid this still doesn't work here... see #129. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-submission of #115; see here for some relevant discussion.
Added note and link to issue description regarding the
SO_REUSEPORTbug in some Kernel versions.Otherwise just reverted the revert, meaning that the NAT removal code from the initial pull request has been re-introduced unmodified. That should make a re-review redundant.