Skip to content

Commit

Permalink
zap unused Field.small[EH] attributes
Browse files Browse the repository at this point in the history
  • Loading branch information
@mohawk2
mohawk2 committed Oct 3, 2021
1 parent 959466b commit b4d7c7f
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 50 deletions.
14 changes: 1 addition & 13 deletions lib/Photonic/LE/NR2/Field.pm
View file
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ the components.
=over 4
=item * new(haydock=>$nr, nh=>$nh, smallE=>$smallE)
=item * new(haydock=>$nr, nh=>$nh)
Initializes the structure.
Expand All @@ -68,9 +68,6 @@ structure, *initialized* with the flag keepStates=>1
$nh is the maximum number of Haydock coefficients to use.
$smallE is the criteria of convergence (default 1e-7) for
Field calculations
=item * evaluate($epsA, $epsB...)
Returns the microscopic electric field for given
Expand All @@ -90,11 +87,6 @@ Photonic::LE::NR2::Haydock structure
Maximum number of Haydock coefficients to use.
=item * smallE
Criteria of convergence. 0 means don't check.
* check remark *
=item * epsA
Dielectric function of component A
Expand Down Expand Up @@ -151,10 +143,6 @@ has 'epsL' =>(is=>'ro', isa=>PDLComplex, init_arg=>undef,
documentation=>'Longitudinal dielectric response');
has 'nh' =>(is=>'ro', isa=>Num, required=>1,
documentation=>'Desired no. of Haydock coefficients');
has 'smallH'=>(is=>'ro', isa=>Num, required=>1, default=>1e-7,
documentation=>'Convergence criterium for Haydock coefficients');
has 'smallE'=>(is=>'ro', isa=>Num, required=>1, default=>1e-7,
documentation=>'Convergence criterium for use of Haydock coeff.');
has 'epsA'=>(is=>'ro', isa=>PDLComplex, init_arg=>undef, writer=>'_epsA',
documentation=>'Dielectric function of host');
has 'epsB'=>(is=>'ro', isa=>PDLComplex, init_arg=>undef, writer=>'_epsB',
Expand Down
2 changes: 1 addition & 1 deletion lib/Photonic/LE/NR2/SHChiTensor.pm
View file
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ sub evaluate {
sub _build_nrshp { # One Haydock coefficients calculator per direction0
my $self=shift;
my $haydock = make_haydock($self, 'Photonic::LE::NR2::Haydock', $self->geometry->unitPairs, 1, qw(reorthogonalize use_mask mask));
my @args=(nh=>$self->nhf, smallE=>$self->smallE);
my @args=(nh=>$self->nhf);
push @args, filter=>$self->filter if $self->has_filter;
[ map Photonic::LE::NR2::SHP->new(
nrf=>Photonic::LE::NR2::Field->new(@args, haydock=>$_),
Expand Down
13 changes: 1 addition & 12 deletions lib/Photonic/LE/S/Field.pm
View file
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ the components.
=over 4
=item * new(haydock=>$haydock, nh=>$nh, smallE=>$smallE)
=item * new(haydock=>$haydock, nh=>$nh)
Initializes the structure.
Expand All @@ -67,9 +67,6 @@ structure, *initialized* with the flag keepStates=>1
$nh is the maximum number of Haydock coefficients to use.
$smallE is the criteria of convergence (default 1e-7) for
Field calculations
=item * evaluate()
Returns the microscopic electric field.
Expand All @@ -88,10 +85,6 @@ Photonic::LE::S::Haydock structure
Maximum number of Haydock coefficients to use.
=item * smallE
Criteria of convergence. 0 means don't check.
=item * epsA
Dielectric function of component A
Expand Down Expand Up @@ -148,10 +141,6 @@ has 'epsL' =>(is=>'ro', isa=>PDLComplex, init_arg=>undef,
documentation=>'Longitudinal dielectric response');
has 'nh' =>(is=>'ro', isa=>Num, required=>1,
documentation=>'Desired no. of Haydock coefficients');
has 'smallH'=>(is=>'ro', isa=>Num, required=>1, default=>1e-7,
documentation=>'Convergence criterium for Haydock coefficients');
has 'smallE'=>(is=>'ro', isa=>Num, required=>1, default=>1e-7,
documentation=>'Convergence criterium for use of Haydock coeff.');
# Not needed for spinor calculation
#has 'epsA'=>(is=>'ro', isa=>PDLComplex, init_arg=>undef, writer=>'_epsA',
# documentation=>'Dielectric function of host');
Expand Down
13 changes: 1 addition & 12 deletions lib/Photonic/WE/R2/Field.pm
View file
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ the components.
=over 4
=item * new(haydock=>$haydock, nh=>$nh, smallE=>$smallE)
=item * new(haydock=>$haydock, nh=>$nh)
Initializes the structure.
Expand All @@ -67,9 +67,6 @@ structure, *initialized* with the flag keepStates=>1
$nh is the maximum number of Haydock coefficients to use.
$smallE is the criteria of convergence (default 1e-7) for
Field calculations
=item * evaluate($epsB)
Returns the microscopic electric field for given
Expand All @@ -90,10 +87,6 @@ Photonic::WE::R2::Haydock structure
Maximum number of Haydock coefficients to use.
=item * smallE
Criteria of convergence. 0 means don't check.
=item * epsA
Dielectric function of component A, which it gets from the Haydock
Expand Down Expand Up @@ -143,10 +136,6 @@ has 'field'=>(is=>'ro', isa=>PDLComplex, init_arg=>undef,
writer=>'_field', documentation=>'Calculated real space field');
has 'nh' =>(is=>'ro', isa=>Num, required=>1,
documentation=>'Desired no. of Haydock coefficients');
has 'smallH'=>(is=>'ro', isa=>Num, required=>1, default=>1e-7,
documentation=>'Convergence criterium for Haydock coefficients');
has 'smallE'=>(is=>'ro', isa=>Num, required=>1, default=>1e-7,
documentation=>'Convergence criterium for use of Haydock coeff.');
has 'epsA'=>(is=>'ro', isa=>PDLComplex, init_arg=>undef, writer=>'_epsA',
documentation=>'Dielectric function of host');
has 'epsB'=>(is=>'ro', isa=>PDLComplex, init_arg=>undef, writer=>'_epsB',
Expand Down
13 changes: 1 addition & 12 deletions lib/Photonic/WE/S/Field.pm
View file
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ the components.
=over 4
=item * new(haydock=>$haydock, nh=>$nh, smallE=>$smallE)
=item * new(haydock=>$haydock, nh=>$nh)
Initializes the structure.
Expand All @@ -67,9 +67,6 @@ structure, *initialized* with the flag keepStates=>1
$nh is the maximum number of Haydock coefficients to use.
$smallE is the criteria of convergence (default 1e-7) for
Field calculations
=item * evaluate
Returns the microscopic electric field
Expand All @@ -88,10 +85,6 @@ Photonic::WE::S::Haydock structure
Maximum number of Haydock coefficients to use.
=item * smallE
Criteria of convergence. 0 means don't check.
=item * epsA
Dielectric function of component A
Expand Down Expand Up @@ -144,10 +137,6 @@ has 'field'=>(is=>'ro', isa=>PDLComplex, init_arg=>undef,
writer=>'_field', documentation=>'Calculated real space field');
has 'nh' =>(is=>'ro', isa=>Num, required=>1,
documentation=>'Desired no. of Haydock coefficients');
has 'smallH'=>(is=>'ro', isa=>Num, required=>1, default=>1e-7,
documentation=>'Convergence criterium for Haydock coefficients');
has 'smallE'=>(is=>'ro', isa=>Num, required=>1, default=>1e-7,
documentation=>'Convergence criterium for use of Haydock coeff.');

sub BUILD {
my $self=shift;
Expand Down

0 comments on commit b4d7c7f

Please sign in to comment.