Skip to content

Commit

Permalink
Remove unnecessary keyword this from functions
Browse files Browse the repository at this point in the history
Also, update the changelog and package patch version.
  • Loading branch information
Walmyr Filho authored and wlsf82 committed Nov 7, 2019
1 parent 5d51c1f commit 34ba2d0
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 5 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
@@ -1,3 +1,7 @@
# 4.0.5

- Remove unnecessary keyword this from functions

# 4.0.4

- Increase code coverage
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
@@ -1,6 +1,6 @@
{
"name": "protractor-helper",
"version": "4.0.4",
"version": "4.0.5",
"scripts": {
"pretest": "webdriver-manager update --gecko false",
"test": "jasmine test/spec/*.spec.js && protractor test/e2e/protractor.conf.js",
Expand Down
6 changes: 3 additions & 3 deletions src/inputFieldInteractions.js
Expand Up @@ -43,16 +43,16 @@ const clearFieldAndFillItWithText = function(
text = utils.requiredParam(clearFieldAndFillItWithText, "text"),
timeoutInMilliseconds = utils.timeout.timeoutInMilliseconds
) {
this.clear(htmlElement, timeoutInMilliseconds);
this.fillFieldWithText(htmlElement, text, timeoutInMilliseconds);
clear(htmlElement, timeoutInMilliseconds);
fillFieldWithText(htmlElement, text, timeoutInMilliseconds);
};

const fillFieldWithTextAndPressEnter = function(
htmlElement = utils.requiredParam(fillFieldWithTextAndPressEnter),
text = utils.requiredParam(fillFieldWithTextAndPressEnter, "text"),
timeoutInMilliseconds = utils.timeout.timeoutInMilliseconds
) {
this.fillFieldWithText(htmlElement, text + protractor.Key.ENTER, timeoutInMilliseconds);
fillFieldWithText(htmlElement, text + protractor.Key.ENTER, timeoutInMilliseconds);
};

module.exports = {
Expand Down

0 comments on commit 34ba2d0

Please sign in to comment.