Prepare protractor helper to work with async await #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PauloGoncalvesBH, o BCH falhou, mas revise mesmo assim, please. |
Also, work around temporarily on function `tapWhenTappable`.
`browser.ignoreSynchronization` will be soon deprecated.
This intends to fix an issue introduced after implementing the usage of async/await, where units of code turned not being short enough anymore based on BetterCodeHub analysis.
async/await is a feature of ES7 that is only available from v8+ versions of NodeJS.
wlsf82
force-pushed
the
prepare-protractor-helper-to-work-with-async-await
branch
from
68787e2
to
ecd7063
Compare
|
All the commits done so far are ok. |
|
Suggestion: Add the keyword testing on package.json file. |
This is necessary to be one of the projects suggested in the topic 'testing' on npmjs.com.
|
@PauloGoncalvesBH, I've just pushed the code with your suggestion. Back to you. |
The commit daa8e68 is ok also. |
Let's make this adjustment in another PR. |
This was referenced Feb 1, 2019
wlsf82
pushed a commit
that referenced
this pull request
Apr 1, 2019
protractor-helper is still not compatible with protractor v6 Waiting on #25
wlsf82
pushed a commit
that referenced
this pull request
Apr 3, 2019
protractor-helper is still not compatible with protractor v6 Waiting on #25
wlsf82
pushed a commit
that referenced
this pull request
Apr 16, 2019
protractor-helper is still not compatible with protractor v6 Waiting on #25
|
I'm closing this PR without merging since it's super outdated and it has too many conflicts. I may use some of its implementations in the new one when addressing issue #21 again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the lib to be prepared to work with async/await, and it is related to issue #21.
Pull Request Checklist
Other comments
index.jsinto smaller and less coupled modules #22) may need to be implemented together in this PR, to fix the Better Code Hub analysis, or we could simply do this in another PR, which I'm in favor of.