Pass logging debug parameter to http attribute #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusschanta
commented
Jul 17, 2023
| @@ -41,7 +41,7 @@ def __init__(self, username, password, http_session=None, debug=False): | |||
| else: | |||
| self.log.setLevel(logging.WARNING) | |||
|
|
|||
| self.http = Http(username=username, password=password, http_session=http_session) | |||
There was a problem hiding this comment.
The debug parameter is currently not passed to the Http instance.
There was a problem hiding this comment.
Maybe add another parameter debug_http to not spam logs, if you do not need the http logs?
There was a problem hiding this comment.
Any updates on this? I mean there is a debug parameter now but it is not working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, 👋
this is a really useful library and I would like to use it as part of a bigger project. For that, I would like to be able to control the logging behaviour of the library in a more granular way:
Currently, the interface class has a debug parameter but this is not passed to the http attribute. This pull request is changing this behaviour so that the debug parameter is passed down consistently which allows better control for the logging behaviour the http class.