UPDATES!! #8
UPDATES!! #8
Conversation
|
There was a problem hiding this comment.
Need to separate version update changes from feature changes with separate commits.
Changes to DigitalHomeCinemaManager/Controls/Settings/GeneralSettings.xaml are unnecessary.
Changes to DigitalHomeCinemaManager/Controls/Settings/GeneralSettings.xaml.cs are generally ok but should continue to use Environment.SpecicalFolder.MyVideos for exceptions. Again, randomize function should be removed.
Movie filter should remain .mkv only.
Changes of date from lowercase to uppercase will not be merged for style reasons. CA1308 was explicitly disabled for this reason.
No reason for clockTimer to have 1s resolution. This change unnecessarily increases calls to OnTimerElapsed handler.
PlaylistSelectionWindow should not support multi-select by default. Instead a Multiselect property should be added to the PlaylistSelectionWindow class. Multiselect ok for Preroll, Trailers, and Commercials but not Feature.
Margin change to Dolby logo unnecessary.
Combination of time hour/minute ok, but time display should remain hh:mm only.
I don't understand the rationale for the log output move.
It doesn't really fit the use case at least not for Preroll or Commercials. I do think randomization or number limit might fit for Trailers, but even then I'm not convinced of the necessity. |
Yeah, that's a typo on my end, it's meant for the trailers.
This would be used when your playlist contains multiple trailers, so it'll automatically shuffle them when added.
That was an accident and I forgot to move it back
It doesn't fit on small screens, but on large screens is easy to see
Did you actually test this feature yourself? It only does this on Trailers and Prerolls, not Commercials or the Feature
I tried this, but it ended up making the folder dialog buggy
Why? Most of the movies I have are .mp4 and .mkv so only a select few would actually be playable
Would clearing the playlist be a bad thing? What if a user wants a completely different playlist? Then they'd have to manually remove everything they have on it already. And this also includes tooltips to help better understand the buttons
This is for the clock display |
Fixed/Added Audio Monitoring Adding future support for API Added Randomizer for Trailers Fixed Multiselect for Trailers & Prerolls (Only Trailers support it now) Added Tooltips to more buttons
|
You're not gonna accept the changes I've made anyways ¯_(ツ)_/¯ |
• Updated from .NET 4.5 to .NET 4.8
• Updated other Packages
• Supports adding multiple files at once to Trailers and Prerolls
• Fixed Time and Date
• Moved Logs for bigger screens
• Added Placeholder options for Randomized Prerolls and Specified amount of Prerolls
(Someone else needs to implement these features 😜)
• Movies/Feature Supports more formats
• Proper Folder Picker