Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs with correct type for string dates #250

Merged
merged 1 commit into from Oct 12, 2019

Conversation

hugofelp
Copy link
Contributor

It is confusing to have type Date in the documentation, when, in reality, a String is expected.

It is confusing to have type Date in the documentation, when, in reality, a String is expected.
@LorienHW
Copy link
Contributor

A little context relating to this issue - We are having to update our code now that calls RNCalendarEvents API's because we were previously passing Date objects to the API's, and it used to work fine. We now have upgraded to RN 59, and now we are getting errors in iOS. I think something must have changed in the RN bridge related code that now breaks if you pass JS Date objects across the bridge to be converted to NSDate objects. Updating our code to pass strings instead works correctly.

@wmcmahan wmcmahan merged commit 73d654d into wmcmahan:master Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants