Remove MediaWiki wgExtensionCredits registration #75
Conversation
|
I think the hassle a breaking change causes is not worth it to get rid of this constant and suggest to put it on the TODO list for whenever there is something justifying that hassle. |
|
This extension has been recently migrated to gerrit: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/DataTypes and hence all changes should be submitted there, not here on github. |
|
@JeroenDeDauw: Sure, that sounds fine to me. This pull request can wait. As I tried to explain in the description above we need to do something more significant with this component anyway. @manicki: This is quite frustrating. Why is this repository here not turned into a mirror then? |
|
About the change itself: I agree with what @JeroenDeDauw said. But actually what bugs me more is the background you provided, quoted below:
As I asked in the other place yesterday, I wonder how splitting, reorganizing etc this extension became the topic right now? I was not part of making this decision on 21.09, but I do remember a real-life discussion few days earlier, you were also part of it, where the conclusion seemed to me to be that we leave this as an extension for now, just move it to gerrit (which happened), and do not do any changes/split/reorg/whatever to it for now. |
|
To be clear: I don't think the current state of this extension is good, it is a weird mixture of stuff just happening to be a MW extension. But if it is intended to reorganize it now, is there some timeline for this? As my understanding is it is intended to have this extension deployed as the regular MW extension on WMF production cluster, it would be good if the intended reorg either happens and is finished before changes to deploying Wikibase-related extensions happen (which means next few weeks), or once the build step clean up is finished and the dust has set. Doing the reorg during the changes to the build step is going to be in the very best case confusing. |
I don't know why, but apparently it has not. I will try to do this today. |
|
I'm afraid I don't get the context of most of your questions. I wrote "in preparation" and "possible split". This needs to be discussed and decided in the team first. What I did in this patch here was playing around with a simple idea to get rid of basically irrelevant code that has nothing to do with the question how this component might be split in the future. I explained how I could imagine such a split. This does not mean somebody is working on this right now. |
|
Basically context being the topic of the possible split was brought up as part of Wikidata "sprint planning", with no further details. My view on this: I'd suggest not touch it for now, especially given what you said in your last comment. |
This is a breaking change because I'm removing a constant.
The idea is to simplify this component a bit. Everything I'm removing here is related to this component being listed under [[Special:Version]]. We are not doing this any more for pure PHP libraries. The same information is in composer.json, and [[Special:Version]] will list libraries based on that (when the library is pulled in by core).
This patch here is done in preparation for a possible split of this component: non-MediaWiki related PHP code should go to DataModel, MediaWiki-related to the Wikibase/lib folder (or to a new MediaWiki extension), and the remaining JavaScript code most probably to Wikibase/view (or to a new component).