GlobeCoordinate: support other globes #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| @@ -40,7 +40,7 @@ | |||
| throw new Error( 'Longitude (' + this._longitude + ') is out of bounds' ); | |||
| } | |||
|
|
|||
| this._globe = 'http://www.wikidata.org/entity/Q2'; // TODO: Support other globes | |||
| this._globe = gcDef.globe; | |||
There was a problem hiding this comment.
maybe gcDef.globe || 'http://www.wikidata.org/entity/Q2' just in case?
|
Thanks a lot for changes. I just wanted to merge this but found that Fomafix is right: Notes:
|
|
Right. Thank you. |
| { latitude: 5, longitude: -0.00292, precision: 1 / 36000 } | ||
| { latitude: 5, longitude: -0.00292, precision: 1 / 36000 }, | ||
| { latitude: 5, longitude: 2, globe: 'http://www.wikidata.org/entity/Q2' }, | ||
| { latitude: 5, longitude: 2, globe: 'http://www.wikidata.org/entity/Q313' } |
There was a problem hiding this comment.
The test error is caused by a bug in equals. I will fix it in an other patch. To make your patch pass please add precision: 1 to these lines.
There was a problem hiding this comment.
Thx, it puzzled me.
Prefer the injected value instead of the hard-coded 'http://www.wikidata.org/entity/Q2'. Add tests. Bug: T105321
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer the injected value instead of the hard-coded 'http://www.wikidata.org/entity/Q2'.
Add tests.
Bug: T105321