Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getEuros method #22

Merged
merged 1 commit into from May 24, 2022
Merged

Add getEuros method #22

merged 1 commit into from May 24, 2022

Conversation

Abban
Copy link
Member

@Abban Abban commented May 23, 2022

Membership Applications store the floored euro amount and currently converts the return value from getEuroFloat(). This PR internalises the functionality.

PR: wmde/fundraising-memberships#100
Ticket: https://phabricator.wikimedia.org/T305051

@Abban Abban requested review from gbirke and moiikana May 23, 2022 11:47
@Abban Abban force-pushed the get-euros branch 3 times, most recently from f3473eb to 25d4091 Compare May 23, 2022 11:56
tests/Unit/EuroTest.php Show resolved Hide resolved
Membership Applications store the floored euro
amount and currently converts the return
value from getEuroFloat(). This PR internalises
the functionality.

PR: wmde/fundraising-memberships#100
Ticket: https://phabricator.wikimedia.org/T305051
@Abban Abban merged commit dfcfb7a into master May 24, 2022
@Abban Abban deleted the get-euros branch May 24, 2022 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants