added updater tests #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
August 3, 2015 13:09
|
There are probably still some other tests that could be added but it is definitely a step forward |
|
|
||
| $this->updateDatabaseBySchema( $schemaTo ); | ||
|
|
||
| $this->assertArrayNotHasKey( |
There was a problem hiding this comment.
This violates Arrange Act Assert. As does the change I made to the already existing test a few days ago. In this case I think it makes sense to break the rule, though do keep it in mind for other things. Just saying - this commit is perfectly fine - I want to avoid starting a series of actually bad AAA violations :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slightly refactored and extended updater testes
follow up to #14