Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PHP 8.1 a new deprecation error is triggered because the
getIterator()
andgetCount()
methods don't conform to the built inTraversable
andCountable
interfaces.For example:
PHP Deprecated: Return type of WMDE\PsrLogTestDoubles\LogCalls::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
andPHP Deprecated: Return type of WMDE\PsrLogTestDoubles\LogCalls::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
The 2 ways to fix this is either add an attribute is either to add the return typehint or to add the attribute. Since on PHP 7.1 these methods didn't have a return typehint, and covariance/contravariance is only fully supported in 7.4, adding the attribute should be more backwards compatible because they will just be treated as comments versions before 8.0.