Simplify calendar model detection code #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -187,16 +187,18 @@ private function getPrecisionFromYear( $year ) { | |||
| * @return string URI | |||
| */ | |||
| private function getCalendarModel( array $timeParts ) { | |||
| $calendarModelName = $timeParts[7]; | |||
| list( $sign, $unsignedYear, , , , , , $calendarModel ) = $timeParts; | |||
There was a problem hiding this comment.
That's how the style must be in my opinion: always a space after a comma. The fact that some elements are skipped doesn't make the whitespace rule obsolete.
mariushoch
added a commit
that referenced
this pull request
May 16, 2015
Simplify calendar model detection code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #66 (comment). This is pure refactoring that doesn't change any semantics. Instead of first re-concatenating sign and year, both are checked independently. The strlen check is not necessary. Even if an INT32 "overflow" happens, it will not cause any trouble because PHP doesn't overflow like C.