[WIP] Unlocalize months in YearMonthDayTimeParser #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmfgerrit
pushed a commit
to wikimedia/mediawiki-extensions-Wikibase
that referenced
this pull request
Sep 29, 2015
This is pure refactoring. The goal is to make this parser independent from MediaWiki core. Note that this is only a first step. Please review and merge this as it is. More will be done in later patches. This patch is motivated by wmde/Time#93 where I do the same to the YearMonthDayTimeParser. Both should use the same array( localized month names => numbers ) in the end. This array will be constructed in the TimeParserFactory (that's the reason for the @see). Change-Id: I2e35005a557180ff955678cfc0ed0e3d8a3e13b8
thiemowmde
force-pushed
the
ymdMonthNames
branch
from
00cf690
to
4f0b3ed
Compare
thiemowmde
force-pushed
the
ymdMonthNames
branch
from
4f0b3ed
to
7ee93b7
Compare
thiemowmde
force-pushed
the
ymdMonthNames
branch
from
7ee93b7
to
203ffd9
Compare
|
Closing very old PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an unfinished work in progress. I'm not sure if this is the right thing to do. Problem is: this messes with the original idea of this super-simple parser to extract three numbers from the input and simply ignore all non-digits. This is critical for inputs like "31 de 12 de 2015" but also means odd stuff like "31 February 12 2015" is parsed successfully. This patch would change that.
What I want to do:
Bug: T98194