Add InArrayUsage sniff

[thiemowmde]

Custom sniff that finds unnecessary slow in_array() that can be replaced with array_key_exists() or isset().

Pinging @legoktm as he might be interested.

[legoktm]

To clarify, this is about finding calls like in_array( array_keys( ... ) ) right?

[JeroenDeDauw]

That is what I understood from looking at it

[lucaswerkmeister]

Isn’t this a false positive? array_keys is not a function call here.

[thiemowmde]

This is intentional. The tokenizer does not know what a function call is. All I can look for is a T_STRING token.

[lucaswerkmeister]

Or a T_STRING token followed by a T_LPAREN or whatever the ( token is called? (Probably with whitespace in between, and comments…)

[thiemowmde]

Sure, but why? What false-positive would that avoid? Bareword strings? ;-)

[lucaswerkmeister]

Okay, fair enough ;)

[lucaswerkmeister]

No tests for array_flip instead of array_keys?

[thiemowmde]

Yea, I was a little sloppy. I will add one.

[thiemowmde]

Done.

[lucaswerkmeister]

This doesn’t seem to work inside an if:

    public function queryConstraintsForProperty( PropertyId $propertyId ) {
        $id = $propertyId->getSerialization();
        if ( !in_array( $id, array_keys( $this->cache ) ) ) {
            $this->cache[$id] = $this->lookup->queryConstraintsForProperty( $propertyId );
        }
        return $this->cache[$id];
    }

No warning on this code. (If I copy one of the failing lines from the tests here into the file, it triggers an error, so I know the sniffer runs.)

[thiemowmde]

I found the issue and fixed the sniff. Awesome you found this!

[lucaswerkmeister]

Cool, thanks! Let’s merge :)