Skip to content
This repository has been archived by the owner on Jan 12, 2021. It is now read-only.

Update the used MediaWiki rule set to 0.10.1 #17

Merged
merged 1 commit into from Jan 26, 2018
Merged

Update the used MediaWiki rule set to 0.10.1 #17

merged 1 commit into from Jan 26, 2018

Conversation

thiemowmde
Copy link
Collaborator

I carefully reviewed the new sniffs that come with this version, and I believe they are fine:

  • Backtick operators, short casts, and &$this references don't even exist in our code bases, and should not, so these additions are fine.
  • We obviously need to allow PHP 7 syntax later when we finally dropped PHP 5 support. But this will take a while and should be done via separate releases. For the moment I suggest to stick to what the MediaWiki rule set does, and not opt-out of this sniff.

Warning, #16 should be merged first!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants