This repository has been archived by the owner on Jan 12, 2021. It is now read-only.
Add Travis configuration #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, I don’t see anything coverage-related in the WikibaseDataModel file – the main difference I can see is the missing notifications. This commit itself looks good to me, but now I’m confused about the commit message… |
|
That was a mistake. I looked at several existing Travis configurations, and many of them contain a section about test coverage. |
| @@ -53,6 +53,7 @@ public function testCodeSnifferStandardFiles( $sniff, $file ) { | |||
| $config = new Config(); | |||
| $config->standards = [ __DIR__ . '/..' ]; | |||
| $config->sniffs = [ $sniff ]; | |||
| $config->reportWidth = 140; | |||
There was a problem hiding this comment.
Yes. Without this, Travis uses a default of 80, which changes all test outputs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly copy-pasted from https://github.com/wmde/WikibaseDataModel/blob/master/.travis.yml, except for the notifications. Also there is nothing about coverage, as it is not relevant here.