Skip to content

Commit

Permalink
Merge pull request #747 from wmde/expectedFirst
Browse files Browse the repository at this point in the history
Flip mixed $expected and $actual parameters
  • Loading branch information
Ladsgroup committed Jun 15, 2017
2 parents 497d6b6 + 756c013 commit 7737e66
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion tests/unit/Entity/BasicEntityIdParserTest.php
Expand Up @@ -24,7 +24,7 @@ public function testCanParseEntityId( $idString, EntityId $expected ) {
$parser = new BasicEntityIdParser();
$actual = $parser->parse( $idString );

$this->assertEquals( $actual, $expected );
$this->assertEquals( $expected, $actual );
}

public function entityIdProvider() {
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/Entity/DispatchingEntityIdParserTest.php
Expand Up @@ -29,7 +29,7 @@ public function testCanParseEntityId( $idString, EntityId $expected ) {
$parser = $this->getBasicParser();
$actual = $parser->parse( $idString );

$this->assertEquals( $actual, $expected );
$this->assertEquals( $expected, $actual );
}

public function entityIdProvider() {
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/Entity/ItemIdParserTest.php
Expand Up @@ -22,7 +22,7 @@ public function testCanParseEntityId( $idString, ItemId $expected ) {
$parser = new ItemIdParser();
$actual = $parser->parse( $idString );

$this->assertEquals( $actual, $expected );
$this->assertEquals( $expected, $actual );
}

public function entityIdProvider() {
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/LegacyIdInterpreterTest.php
Expand Up @@ -25,7 +25,7 @@ class LegacyIdInterpreterTest extends \PHPUnit_Framework_TestCase {
public function testNewIdFromTypeAndNumber( EntityId $expected, $type, $number ) {
$actual = LegacyIdInterpreter::newIdFromTypeAndNumber( $type, $number );

$this->assertEquals( $actual, $expected );
$this->assertEquals( $expected, $actual );
}

public function idProvider() {
Expand Down

0 comments on commit 7737e66

Please sign in to comment.