Clean up entity patching code

[JeroenDeDauw]

TL;DR: split patching code from Entity and did the same with its tests

Done:

• split patching code from Entity and derivatives
• drop usage of deprecated term related methods defined by Entity
• split Fingerprint patching code into its own class
• split Statement patching code into its own class
• split SiteLink patching code into its own class
• drop usage of deprecated claim related methods defined by Entity
• drop usage of deprecated Item methods
• fully replicate the old tests and then remove them from EntityTest and derivatives

[JeroenDeDauw]

@WMDE-Fisch @Benestar FYI

[Benestar]

indentation issue

[JeroenDeDauw]

wtf?? Guess I need to file a fifth PhpStorm 8.0 bug then!

[JeroenDeDauw]

Or not. Added in 186fbd7, so guess @WMDE-Fisch does not have his IDE set to tabs. Heresy! :)

[JeroenDeDauw]

Let's do some bets :)

• EntityTest F -> E
• ItemTest D -> C
• Entity B -> A
• Item B -> A
• Global score 9.06 -> 9.11

Edit: found you can cheat by checking https://scrutinizer-ci.com/g/wmde/WikibaseDataModel/inspections/3c5ffa61-9677-4995-8a9d-7bc119f0e878

• EntityTest F -> C (yay)
• ItemTest D -> D (sad)
• Entity B -> B (sad)
• Item B -> B (sad)
• Global score 9.06 -> 9.23 (woot)

[JeroenDeDauw]

@addshore For great rating! :)

[Benestar]

Still indentation issues

[Benestar]

Not a problem of this patch but we have to remember that this isn't very sane. EntityDiff should not know about claims.

[JeroenDeDauw]

It should also not know about fingerprints. And the "claims" in the names here should be changed to "statements". That's an EntityDiff problem though, which is for another time.

[Benestar]

-1 for the Statement/Claim confusion

[JeroenDeDauw]

-1 for the Statement/Claim confusion

Removed now

[Benestar]

I don't see the benefit of this interface. EntityDocument is only about ids and the ids will never get patched because they are immutable. Therefore we will also most likely kill the EntityDiff class entirely because it contains now EntityStuff but only stuff specific for fingerprints or claims/statements.

[JeroenDeDauw]

The reason we have this interface is so that we can have EntityPatcher, or rather the functionality EntityPatcher provides. The users of DataModel have places where they have something of type Entity and need to patch it. In many cases having something of an unknown Entity types is bad, but still DM needs to support its current users. This dispatcher + strategy approach allows DM to support this without itself having any patching logic that deals with entities of unknown type.