Drop unused HashArray::removeDuplicates #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiemowmde
force-pushed
the
removeDuplicates
branch
2 times, most recently
from
a8cc425
to
d91d265
Compare
|
Merge conflict |
thiemowmde
force-pushed
the
removeDuplicates
branch
from
d91d265
to
2630523
Compare
|
That was expected. I manually rebased it now. Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is split from #702 to make it easier to review.
Note that we already removed ReferenceList::removeDuplicates in 5.0.
The two testHasElement and testRemoveElement tests are moved without touching them, because they are not applicable to a test setup with duplicates.