Rework native EntityId(Value) serializations #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brightbyte
suggested changes
Feb 9, 2017
| @@ -114,7 +114,7 @@ public function serializationProvider() { | |||
| [ '["",""]', '' ], | |||
| [ '["",2]', 2 ], | |||
| [ '["",null]', null ], | |||
| [ '', null ], | |||
| [ '', '' ], | |||
There was a problem hiding this comment.
Should test new serialization format: [ 'Q2', 'Q2' ],
There was a problem hiding this comment.
Done for both ItemId and PropertyId.
| @@ -92,7 +92,7 @@ public function testGetEntityType() { | |||
|
|
|||
| public function testSerialize() { | |||
There was a problem hiding this comment.
there is no test for Propertyid::unserialize?!
There was a problem hiding this comment.
There is, see line 101 below.
thiemowmde
force-pushed
the
idSerialize
branch
from
8a3e451
to
614ebfb
Compare
brightbyte
approved these changes
Feb 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative draft for #716. Pinging @brightbyte and @JeroenDeDauw.
This patch does 2 things:
serializeinstead of JSON.The 1st change makes the serialized string much longer, the 2nd change minimizes it again.
In all cases I keep compatibility with the previous serialization formats.