Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded @phpcs:disable comments #830

Merged
merged 1 commit into from Oct 16, 2020
Merged

Remove unneeded @phpcs:disable comments #830

merged 1 commit into from Oct 16, 2020

Conversation

lucaswerkmeister
Copy link
Member

No description provided.

@micgro42
Copy link
Collaborator

Thanks, looks good so far. Could you check if we also still need the extended ignore syntax added in this line:

https://github.com/wmde/WikibaseDataModel/pull/824/files#diff-86663aeec12838bb61855e163b38da1d1e38d18276b2d25c9dd6761127914a43R18

micgro42
micgro42 approved these changes Oct 16, 2020
View reviewed changes
Copy link
Collaborator

@micgro42 micgro42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mh, we probably do, the line mentioned above is only related to the maxmethods rule. Will merge once Travis is happy.

@micgro42 micgro42 merged commit 3878d5a into master Oct 16, 2020
@micgro42 micgro42 deleted the phpcs branch October 16, 2020 16:44
@lucaswerkmeister
Copy link
Member Author

Hm, locally composer ci passes even if I completely remove that ignorepattern line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micgro42 micgro42 micgro42 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lucaswerkmeister @micgro42