Fix broken tests that do nothing or test wrong classes #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing this! |
Benestar
added a commit
that referenced
this pull request
Feb 18, 2016
Fix broken tests that do nothing or test wrong classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sheer amount of broken tests I found purely by looking at PHPUnit's code coverage report is incredible.
deserializableProvideris for testingDispatchableDeserializer::isDeserializerFor, but most classes under test do not implement this interface. All these test cases are nothing but dead code. I'm changing the$this->assertTrue( true )to something that fails to make this obvious.array().With this patch, code coverage is at 99.8%. 2 lines are missing. Both are dead code. But I did not wanted to touch this in the same patch.