Make DispatchableDe/Serializer tests as specific as possible #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames base classes and makes them as specific as possible:
All tests on non-dispatchable classes can not use these base classes any more.
I'm also switching to
assertSameto compare the serialized arrays, which makes the order part of the test. Please do not argue with "order is unspecified in JSON". This component does not know anything about JSON. The serializers in this component output PHP arrays. Order is a thing in PHP arrays.This is meant as a base for #198. It will make working on #198 much easier.