Merge pull request #8 from wmde/revertautoloadcommit

Revert "Improve autoloading code"

.travis.yml

@@ -35,7 +35,6 @@ script:
   - if [ "$TESTSUITE" == "MediaWiki" ] ; then phpunit --coverage-clover build/logs/clover.xml ; fi
 
 after_script:
-  - composer require satooshi/php-coveralls dev-master
   - php vendor/bin/coveralls -v
 
 notifications:

WikibaseDatabase.mw.php

@@ -12,10 +12,6 @@
 	die( 'Not an entry point.' );
 }
 
-if ( is_readable( __DIR__ . '/vendor/autoload.php' ) ) {
-	require_once( __DIR__ . '/vendor/autoload.php' );
-}
-
 $GLOBALS['wgExtensionCredits']['wikibase'][] = array(
 	'path' => __DIR__,
 	'name' => 'Wikibase Database',
@@ -30,6 +26,10 @@
 
 $GLOBALS['wgExtensionMessagesFiles']['WikibaseDatabase'] = __DIR__ . '/WikibaseDatabase.i18n.php';
 
+if ( defined( 'MW_PHPUNIT_TEST' ) ) {
+	require_once __DIR__ . '/tests/testLoader.php';
+}
+
 /**
  * Hook to add PHPUnit test cases.
  * @see https://www.mediawiki.org/wiki/Manual:Hooks/UnitTestsList

WikibaseDatabase.php

@@ -3,18 +3,54 @@
 /**
  * Entry point of the Wikibase Database component.
  *
- * @codeCoverageIgnore
- *
  * @licence GNU GPL v2+
  * @author Jeroen De Dauw < jeroendedauw@gmail.com >
  */
 
-if ( !defined( 'WIKIBASE_DATABASE_VERSION' ) ) {
-	define( 'WIKIBASE_DATABASE_VERSION', '0.2 alpha' );
+if ( defined( 'WIKIBASE_DATABASE_VERSION' ) ) {
+	// Do not initialize more then once.
+	return;
+}
+
+define( 'WIKIBASE_DATABASE_VERSION', '0.1' );
+
+spl_autoload_register( function ( $className ) {
+	$className = ltrim( $className, '\\' );
+	$fileName = '';
+	$namespace = '';
+
+	if ( $lastNsPos = strripos( $className, '\\') ) {
+		$namespace = substr( $className, 0, $lastNsPos );
+		$className = substr( $className, $lastNsPos + 1 );
+		$fileName  = str_replace( '\\', '/', $namespace ) . '/';
+	}
+
+	$fileName .= str_replace( '_', '/', $className ) . '.php';
+
+	$namespaceSegments = explode( '\\', $namespace );
+
+	$inQueryEngineNamespace = count( $namespaceSegments ) > 1
+		&& $namespaceSegments[0] === 'Wikibase'
+		&& $namespaceSegments[1] === 'Database';
 
-	if ( defined( 'MEDIAWIKI' ) ) {
-		call_user_func( function() {
-			require_once __DIR__ . '/WikibaseDatabase.mw.php';
-		} );
+	if ( $inQueryEngineNamespace ) {
+		$inTestNamespace = count( $namespaceSegments ) > 2 && $namespaceSegments[2] === 'Tests';
+
+		if ( !$inTestNamespace ) {
+			$pathParts = explode( '/', $fileName );
+			array_shift( $pathParts );
+			array_shift( $pathParts );
+			$fileName = implode( '/', $pathParts );
+
+			require_once __DIR__ . '/src/' . $fileName;
+		}
 	}
+} );
+
+// @codeCoverageIgnoreStart
+if ( defined( 'MEDIAWIKI' ) ) {
+	call_user_func( function() {
+		require_once __DIR__ . '/WikibaseDatabase.mw.php';
+	} );
 }
+// @codeCoverageIgnoreEnd

composer.json

@@ -28,10 +28,10 @@
 	"require": {
 		"php": ">=5.3.2"
 	},
+	"require-dev": {
+		"satooshi/php-coveralls": "dev-master"
+	},
 	"autoload": {
-		"classmap": [
-			"src"
-		],
 		"files" : [
 			"WikibaseDatabase.php"
 		]

tests/bootstrap.php

@@ -9,12 +9,10 @@
  * @author Jeroen De Dauw < jeroendedauw@gmail.com >
  */
 
-if ( !is_readable( __DIR__ . '/../vendor/autoload.php' ) ) {
-	die( 'You need to install this package with Composer before you can run the tests' );
-}
-
 if ( !in_array( '--testsuite=WikibaseDatabaseStandalone', $GLOBALS['argv'] ) ) {
 	require_once( __DIR__ . '/evilMediaWikiBootstrap.php' );
 }
 
-require_once( __DIR__ . '/../vendor/autoload.php' );
+require_once( __DIR__ . '/../WikibaseDatabase.php' );
+
+require_once( __DIR__ . '/testLoader.php' );

tests/testLoader.php

@@ -0,0 +1,41 @@
+<?php
+
+/**
+ * Test class autoloader for the Wikibase Database component.
+ *
+ * @since 0.1
+ *
+ * @licence GNU GPL v2+
+ * @author Jeroen De Dauw < jeroendedauw@gmail.com >
+ */
+
+spl_autoload_register( function ( $className ) {
+	$className = ltrim( $className, '\\' );
+	$fileName = '';
+	$namespace = '';
+
+	if ( $lastNsPos = strripos( $className, '\\') ) {
+		$namespace = substr( $className, 0, $lastNsPos );
+		$className = substr( $className, $lastNsPos + 1 );
+		$fileName  = str_replace( '\\', '/', $namespace ) . '/';
+	}
+
+	$fileName .= str_replace( '_', '/', $className ) . '.php';
+
+	$namespaceSegments = explode( '\\', $namespace );
+
+	$inTestNamespace = count( $namespaceSegments ) > 2
+		&& $namespaceSegments[0] === 'Wikibase'
+		&& $namespaceSegments[1] === 'Database'
+		&& $namespaceSegments[2] === 'Tests';
+
+	if ( $inTestNamespace ) {
+		$pathParts = explode( '/', $fileName );
+		array_shift( $pathParts );
+		array_shift( $pathParts );
+		array_shift( $pathParts );
+		$fileName = implode( '/', $pathParts );
+
+		require_once __DIR__ . '/phpunit/' . $fileName;
+	}
+} );