Merge pull request #106 from wmde/returnTypes

Add missing return types to private methods
wmde · Apr 7, 2016 · edf76e8 · edf76e8
2 parents f74fd54 + 0b70348
commit edf76e8
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/tests/integration/TestFactoryBuilder.php b/tests/integration/TestFactoryBuilder.php
@@ -5,6 +5,7 @@
 use DataValues\Deserializers\DataValueDeserializer;
 use DataValues\Serializers\DataValueSerializer;
 use DataValues\StringValue;
+use Deserializers\Deserializer;
 use PHPUnit_Framework_TestCase;
 use Wikibase\DataModel\Entity\BasicEntityIdParser;
 use Wikibase\InternalSerialization\DeserializerFactory;
@@ -24,6 +25,11 @@ public static function newLegacyDeserializerFactory( PHPUnit_Framework_TestCase
 		);
 	}
 
+	/**
+	 * @param PHPUnit_Framework_TestCase $testCase
+	 *
+	 * @return Deserializer
+	 */
 	private static function newFakeDataValueDeserializer( PHPUnit_Framework_TestCase $testCase ) {
 		$dataValueDeserializer = $testCase->getMock( 'Deserializers\Deserializer' );
 

diff --git a/tests/unit/Deserializers/EntityDeserializerTest.php b/tests/unit/Deserializers/EntityDeserializerTest.php
@@ -3,6 +3,7 @@
 namespace Tests\Wikibase\InternalSerialization\Deserializers;
 
 use Deserializers\Deserializer;
+use Deserializers\DispatchableDeserializer;
 use Deserializers\Exceptions\DeserializationException;
 use Wikibase\InternalSerialization\Deserializers\EntityDeserializer;
 
@@ -26,6 +27,9 @@ protected function setUp() {
 		);
 	}
 
+	/**
+	 * @return DispatchableDeserializer
+	 */
 	private function getStubLegacyDeserializer() {
 		$legacyDeserializer = $this->getMock( 'Deserializers\DispatchableDeserializer' );
 
@@ -42,6 +46,9 @@ private function getStubLegacyDeserializer() {
 		return $legacyDeserializer;
 	}
 
+	/**
+	 * @return DispatchableDeserializer
+	 */
 	private function getStubCurrentDeserializer() {
 		$currentDeserializer = $this->getMock( 'Deserializers\DispatchableDeserializer' );
 
@@ -68,6 +75,9 @@ public function testGivenCurrentSerialization_currentIsDetected() {
 		$this->assertEquals( 'current', $returnValue );
 	}
 
+	/**
+	 * @return DispatchableDeserializer
+	 */
 	private function getThrowingDeserializer() {
 		$currentDeserializer = $this->getMock( 'Deserializers\DispatchableDeserializer' );