Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed dependence on DataModel Services #83

Closed
wants to merge 1 commit into from
Closed

Conversation

JeroenDeDauw
Copy link
Contributor

No description provided.

@Benestar
Copy link
Contributor

-2 this is a breaking change as well as the release in WikibaseDataModelSerialization and will break Wikibase.git as well. Should be done in a 2.0

@addshore
Copy link
Contributor

Yep, -2 also for the tagging.
If there were no typehints this would not be breaking ;)

@@ -106,6 +106,10 @@ Wikibase Internal Serialization has been written by [Jeroen De Dauw]

## Release notes

## 1.6.0 (2015-08-26)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three ### please.

@thiemowmde
Copy link
Contributor

Ouch, this means 1.4.0...1.5.0 was also a breaking change! Same for wmde/WikibaseDataModelSerialization@1.8.0...1.9.0!

Also see wmde/WikibaseDataModelSerialization#167 (comment).

@addshore
Copy link
Contributor

yep, I don't think we considered the typehints breaking everything, need to be careful when changing namespaces apparently.
It is a shame PHP doesn't have something like Use class X or use class Y... ;)

@JeroenDeDauw JeroenDeDauw deleted the rel160 branch August 30, 2015 16:30
@JeroenDeDauw
Copy link
Contributor Author

Ouch, this means 1.4.0...1.5.0 was also a breaking change!

Since the major DM version there was changed, it was not as big of a deal as here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants