Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single datamodel entry #58

Merged
merged 2 commits into from
Oct 1, 2019
Merged

Single datamodel entry #58

merged 2 commits into from
Oct 1, 2019

Conversation

jakobw
Copy link
Member

@jakobw jakobw commented Sep 30, 2019

No description provided.

AlaaSarhan
AlaaSarhan suggested changes Sep 30, 2019
View reviewed changes
Copy link
Collaborator

@AlaaSarhan AlaaSarhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Let's wait until a release is made on wikibase.datamodel instead of depending on a specific commit? Unless urgent, I think following that pattern is better.

package.json Outdated Show resolved Hide resolved
@jakobw
Prepare for wb.datamodel to be loaded via single module
87ac417 
This also changes MockEntity to extend FingerprintableEntity, which it
did implicitly before.
@jakobw
Load datamodel through a single module
92f943f
@jakobw jakobw marked this pull request as ready for review October 1, 2019 14:13
@Ladsgroup Ladsgroup marked this pull request as ready for review October 1, 2019 14:15
@Ladsgroup
Copy link
Contributor

Looks good!

Let's wait until a release is made on wikibase.datamodel instead of depending on a specific commit? Unless urgent, I think following that pattern is better.

It's done now

@Ladsgroup Ladsgroup merged commit 93b564c into master Oct 1, 2019
@Ladsgroup Ladsgroup deleted the single-dm-entry branch October 1, 2019 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlaaSarhan AlaaSarhan AlaaSarhan requested changes

@Ladsgroup Ladsgroup Ladsgroup left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jakobw @Ladsgroup @AlaaSarhan