Add matomo tracking #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzhelyazkova
force-pushed
the
add-matomo-tracking
branch
from
0953df8
to
3ceca61
Compare
gbirke
reviewed
Jul 27, 2018
imprint.html
Outdated
| @@ -81,6 +81,10 @@ <h3>Datenschutzerklärung</h3> | |||
| </div> | |||
| </div> | |||
|
|
|||
| </body> | |||
| <!-- Matomo --> | |||
| <script type="text/javascript" src="tracking.js"></script> | |||
There was a problem hiding this comment.
I like that you're avoiding redundancy by putting the tracking code into a file. However, I'd add async and defer attributes, otherwise loading the page will be blocked by an additional HTTP request.
Feature: T199425
tzhelyazkova
force-pushed
the
add-matomo-tracking
branch
from
3ceca61
to
8ef18c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: T199425