Add member-delimiter-style #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rule [1] ensures a consistent style in interfaces and type literals: always use semicolons (not commas or only newlines), and include a final delimiter iff the type has multiple lines. (The rule is configurable, but the defaults seem fine for us, in my opinion.) [1]: https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/member-delimiter-style.md
|
Tested at wmde/new-lexeme-special-page#76 (see last commit). |
micgro42
approved these changes
Mar 2, 2022
lucaswerkmeister
added a commit
to wmde/new-lexeme-special-page
that referenced
this pull request
Mar 2, 2022
This pulls in wmde/eslint-config-wikimedia-typescript#15, ensuring consistent style in interfaces and type literals.
lucaswerkmeister
added a commit
to wmde/new-lexeme-special-page
that referenced
this pull request
Mar 3, 2022
…ipt (#77) This pulls in wmde/eslint-config-wikimedia-typescript#15, ensuring consistent style in interfaces and type literals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule ensures a consistent style in interfaces and type literals: always use semicolons (not commas or only newlines), and include a final delimiter iff the type has multiple lines. (The rule is configurable, but the defaults seem fine for us, in my opinion.)