Update typescript-eslint and eslint-config-wikimedia #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
The changes look okay to me (except for one comment), but I’d prefer to merge them with a different message. Previously, we updated dependencies separately (e.g. #34, but also dependabot PRs like #28/#31/#33), and the “bump version” commit/PR really only bumped the version and nothing else. This commit updates all the dependencies the package has, so it should have a more prominent message IMHO.
Suggestion:
Update dependencies and bump version to 0.2.7
Upgrade the eslint packages to the latest version. Update eslint-config-wikimedia to 0.26.0 to address peer dependency issue when using this package projects that want a newer version of eslint-plugin-vue. Bug: T341552
codders
force-pushed
the
feat/upgrade-dependencies
branch
from
d1d34b4
to
172c19c
Compare
codders
changed the title
lucaswerkmeister
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the eslint packages to the latest version.
Update eslint-config-wikimedia to 0.26.0 to address peer dependency
issue when using this package projects that want a newer version
of eslint-plugin-vue.
Bug: T341552