Fix data leak when selecting anonymous address type

[Sperling-0]

Ticket: https://phabricator.wikimedia.org/T235017

[Abban]

Looks good, and it's the right way to do it. I just have a couple of things you should do.

• Email only address types send only the email/salutation/title/firstName/lastName so you should split the if statement into 2:
  1. One that checks the address type is email or full and includes the email/salutation/title/firstName/lastName fields.
  2. One that checks the address type is full and includes the other address fields.
• You should add tests to SubmitValues.spec.ts that make sure the correct fields are present for the each address type.

[Abban]

Normally I try to not nest if statements, but this looks okay to me.

You can fix the CI by running npm run test:unit -- -u to clean up the snapshots.

[gbirke]

Thank you for picking this up! While reviewing, I was a bit confused about the nested <template> tags. Maybe you can rework this, by creating two Boolean computed properties, sendPostalAddress and sendNameAndEmail, wrapping the input fields in 2 non-nested template tags that check for these variables. It would also move the comparison logic out of the template section and into the script section, which I like better

[gbirke]

Thank you for incorporating my suggestions!