Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow keyboard navigation for selecting the language #367

Closed
wants to merge 3 commits into from

Conversation

Sperling-0
Copy link
Contributor

@Sperling-0 Sperling-0 commented Apr 22, 2024

  • Fix linting issues in test files
  • Add label for language selection

Ticket: https://phabricator.wikimedia.org/T361781

Deployed to: https://testing01.wikimedia.customers.manitu.net/

@Abban Abban requested review from Abban and moiikana April 25, 2024 08:16
@Sperling-0 Sperling-0 force-pushed the language-keyboard-navigation branch 6 times, most recently from ab93e7e to e57fd83 Compare April 26, 2024 16:36
@Sperling-0 Sperling-0 marked this pull request as ready for review April 29, 2024 07:44
@Sperling-0 Sperling-0 requested a review from gbirke April 29, 2024 07:44
@moiikana moiikana added the 🦮 accessibility code that improves accessibility label Apr 29, 2024
@Sperling-0 Sperling-0 marked this pull request as draft April 30, 2024 06:59
@Sperling-0 Sperling-0 marked this pull request as ready for review May 2, 2024 08:55
@gbirke
Copy link
Member

gbirke commented May 22, 2024

Superseded by #392

@gbirke gbirke closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦮 accessibility code that improves accessibility PM's feedback needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants